-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds gfxreconstruct as a subtree #140
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dispatch and TraceRays outputs now support descriptor arrays
When the replay --use-cached-psos option is not specified, clear the cached PSO data from the ID3D12Device2::CreatePipelineState parameters, similar to what is currently done for the ID3D12Device CreateComputePipelineState and CreateGraphicsPipelineState methods.
For layered API support.
For layered API support.
Layered API support
Prevents uninitialized next/pNext. The lower level decoders aren't always setting values. Set a good state at initialization (zeros) Layered API support.
Prevent collisions with other API consumers and decoders Layered API support.
Split vulkan instance and device creation override into reusable pieces suitable for layered API support (specifically OpenXR) Make neeed information public for other replay consumers Layered API support.
Vulkan captures unwrapped physical device handles, Layered API (like OpenXR) captures wrapped handles. During replay two HandleId's will reference the same VkPhysical device. The vulkan_alias is the handleId as known by the vulkan_consumer, which will be created/updated, etc, by all Vulkan replay calls.
Move replay options around that are shared between multiple replay paths. For layered API support.
Install page guard signal handler using AddSpecialSignalHandlerFn from the libsigchain in the Android runtime. This prevents traced applications from replacing our signal handler when they try to install thier own signal handlers with sigaction. This is implicitly enabled when using page_guard on Android and falls back to sigaction if libsigchain isn't found or the add call fails. If the signal handler watcher is enabled, the watcher thread will exit as soon as our handler is successfully added with libsigchain.
* Fix descriptor info assert during capture * Combine asserts
- various changes to state-writer: always provide shader-group-handles - track bound pipelines in replay, retrieve map of old/new handles in CmdTraceRays - Add a generic murmur32-implementation to util/hash.h - Add a 'linear hashmap' type (cpu-flavor), populate with handles - Add unit-test for linear_hashmap
The DestroyState() overrides added by 1644 should also do what the default DestroyState is doing. This patch should address this omission
Fix invalid conversion errors by casting argument values to their target platform full types. This fixes compilation issues for code like this: ``` VkWaylandSurfaceCreateInfoKHR waylandSurfaceCreateInfoKHR_17 { VkStructureType(1000006000), NULL, VkWaylandSurfaceCreateFlagsKHR(0), 0, 0x2000000, }; ``` which compiled with g++ 14.2.1 20240912 yields this: ``` src/frame_0000_0000.cpp:132:25: error: invalid conversion from ‘int’ to ‘wl_surface*’ [-fpermissive] ```
Use ID3D12GraphicsCommandList4ComPtr to release automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use gfxreconstruct capture/replay, the gfxreconstruct repo needs to be added to dive. Unlike other existing third party libraries in dive, the cmake files for gfxreconstruct are not setup so that it can be easily added to the project. To remedy this, I add gfxreconstruct as a git subtree so that dive specific modifications can be made to gfxreconstruct and the upstream changes can be pulled in to keep our version updated.
Changes: